[PATCH] D115443: [ADT] Weaken the initialization condition in SmallVector::resize_for_overwrite

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 13 15:36:26 PST 2022


dexonsmith added reviewers: jplayer-nv, dblaikie.
dexonsmith added a comment.

(Just seeing this now; sorry for the slow response...)

I think your logic is sound and the patch looks good in principle, except that I wonder if landing it will hit similar problems to https://reviews.llvm.org/D93510 (see also: https://reviews.llvm.org/D117254)

- Older MSVC has trouble with `is_trivially_copyable` (note the Windows pre-merge check failed)
- Older GCC has trouble with `std::is_trivially_copy_constructible` and `std::is_trivally_move_constructible`, which were applied to work around the MSVC troubles


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115443/new/

https://reviews.llvm.org/D115443



More information about the llvm-commits mailing list