[PATCH] D117190: [GlobalValue] Make dso_local function work with comdat nodeduplicate

Luís Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 13 15:09:13 PST 2022


ljmf00 added a comment.

I had to look into the documentation to understand how `comdat` works. Compared to the diffs I generated early this seems fine. I also did a full bootstrap multi-stage build of clang with this patch and the patches and flags used by my host clang. I can't reproduce the issue I described on D102453 <https://reviews.llvm.org/D102453>, so it seems fixed. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117190/new/

https://reviews.llvm.org/D117190



More information about the llvm-commits mailing list