[PATCH] D117250: [lld-macho] Mention string literal deduplication as a difference from ld64

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 13 14:18:02 PST 2022


keith added a comment.

Yea this case is tough. We could always recommend folks enable it with this same warning instead. My biggest worry, similar to the case we hit with this, is that many iOS apps do not control _all_ the code that ships in their apps. Specifically the proliferation of closed source libraries for analytics / fraud / payments are very common, and might have these subtle bugs that developers cannot easily fix. Really I think flipping the default would just be a benefit for folks who were onboarding.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117250/new/

https://reviews.llvm.org/D117250



More information about the llvm-commits mailing list