[PATCH] D108416: [llvm-libgcc] initial commit

[Christopher Di Bella via Phabricator via llvm-commits]

cjdb added inline comments.


================
Comment at: llvm/libgcc/docs/LLVMLibgcc.rst:68
+
+.. option:: `LLVM_LIBGCC_TARGET`
+
----------------
MaskRay wrote:
> Does `LLVM_DEFAULT_TARGET_TRIPLE` help?
Possibly, but there can be ambiguity between x86 and x86_64 since x86 chips aren't really a thing any more and the two terms are often interchangeable.


================
Comment at: llvm/libgcc/docs/LLVMLibgcc.rst:186
+
+Roughly sixty symbols should appear, all suffixed with ``@@GCC_3.0``. You can
+replace ``GCC_3.0`` with any of the supported version names in the version
----------------
MaskRay wrote:
> There are many symbols of other versions.
Yes. It's not really clear to me why you're pointing this out though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108416/new/

https://reviews.llvm.org/D108416