[PATCH] D117250: [lld-macho] Mention string literal deduplication as a difference from ld64

[Jez Ng via Phabricator via llvm-commits]

int3 created this revision.
Herald added a project: lld-macho.
Herald added a reviewer: lld-macho.
int3 requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117250

Files:
  lld/MachO/ld64-vs-lld.rst


Index: lld/MachO/ld64-vs-lld.rst
===================================================================
--- lld/MachO/ld64-vs-lld.rst
+++ lld/MachO/ld64-vs-lld.rst
@@ -4,6 +4,15 @@
 
 This doc lists all significant deliberate differences in behavior between LD64 and LLD-MachO.
 
+String literal deduplication
+****************************
+LD64 always deduplicates string literals. LLD only does it when the `--icf=` or
+the `--deduplicate-literals` flag is passed. Omitting deduplication by default
+ensures that our link is as fast as possible. However, it may also break some
+programs which have (incorrectly) relied on string deduplication always
+occurring. In particular, programs which compared string literals via pointer
+equality must be fixed to use value equality instead.
+
 ObjC symbols treatment
 **********************
 There are differences in how LLD and LD64 handle ObjC symbols loaded from archives.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117250.399774.patch
Type: text/x-patch
Size: 919 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220113/14e9ace1/attachment.bin>