[PATCH] D107193: [Zorg] Honor clean_obj in WebUI.

Thu Jan 13 13:16:29 PST 2022

gkistanova added a comment.

> That is, if clean is set to False, the value of clean_obj does not matter, even if it is True and the build dir is not cleaned. This is what this patch intends to change.

Ah. I missed this point, sorry. Yes, you are right. There is a bug there.

Thanks for updating the patch!

It looks good, you just missed couple places with `doStepIf`s.

================
Comment at: zorg/buildbot/builders/OpenMPBuilder.py:158
                            warnOnFailure=True,
                            doStepIf=cleanBuildRequestedByProperty))

----------------
`cleanBuildRequested` here?

================
Comment at: zorg/buildbot/builders/OpenMPBuilder.py:173
                            warnOnFailure=True,
                            doStepIf=cleanBuildRequestedByProperty))

----------------
`cleanBuildRequested` here?

Repository:
  rZORG LLVM Github Zorg

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D107193/new/

https://reviews.llvm.org/D107193