[PATCH] D117180: [BasicAliasAnalysis] Switch from isMallocOrCallocLikeFn to onlyAccessesInaccessibleMemory

[Bryce Wilson via Phabricator via llvm-commits]

Bryce-MW added a comment.

Based on the comments on AllocType, it seems that the original difference between OpNewLike and MallocLike was whether it returned null. In that context, it's reasonable that something that never returns null can be used in the place of something that could return null. It's obviously used for more than just that now so this has probably caused a few places to be incorrect.

It seems like this patch of just removing the condition entirely should at least make this part of the code correct even though it does change the functionality slightly.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117180/new/

https://reviews.llvm.org/D117180