[PATCH] D117134: [DebugInfo][DWARF][NFC] Move DWARFTypePrinter class to its own file.

Thu Jan 13 11:08:10 PST 2022

dblaikie added a comment.

In D117134#3239597 <https://reviews.llvm.org/D117134#3239597>, @avl wrote:

> In D117134#3239412 <https://reviews.llvm.org/D117134#3239412>, @dblaikie wrote:
>
>> I don't especially object to moving this to a separate file - but maybe it'd be more suitable to have this exposed as a function on DWARFDie, rather than exposing the whole DWARFTypePrinter API?
>
> i.e. something similar to this:
>
>   void DWARFDie::dumpTypeQualifiedName(raw_ostream& OS);
>   void DWARFDie::dumpTypeUnqualifiedName(raw_ostream& OS, std::string *OriginalFullName = nullptr);
>
> If that is a preferred variant - I will change the patch accordingly.
>
> Though, The variant with a separate class has an advantage in that it separates dumping functionality from the DWARFDie class.

Oh, fair point - how about free functions, then? `void dumpTypeQualifiedName(DWARFDie D, raw_ostream &OS)` - that sort of thing?

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117134/new/

https://reviews.llvm.org/D117134