[PATCH] D117057: [AMDGPU] Annotate functions with inline asm using agprs

Tue Jan 11 17:29:09 PST 2022

arsenm added a comment.

In D117057#3235661 <https://reviews.llvm.org/D117057#3235661>, @rampitec wrote:

> In D117057#3235626 <https://reviews.llvm.org/D117057#3235626>, @rampitec wrote:
>
>> I guess I can run this code in the `AMDGPUDAGToDAGISel::runOnMachineFunction` or even `SIMachineFunctionInfo` constructor and skip the attribution.
>
> The downside is that I have to scan all instructions for that, and AMDGPUAnnotateKernelFeatures already does that. Where are you planning to move its code?

AMDGPUAttributor. If this were to be an attribute, which is pretty ugly, it should be the inverse. Why can't you just select to AGPRs, and later we can adjust the register classes if necessary?

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117057/new/

https://reviews.llvm.org/D117057