[PATCH] D117057: [AMDGPU] Annotate functions with inline asm using agprs

Stanislav Mekhanoshin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 14:48:31 PST 2022


rampitec added a comment.

In D117057#3235597 <https://reviews.llvm.org/D117057#3235597>, @arsenm wrote:

> Why does this specifically need to check for inline asm? Is this only checked in the kernel or functions too?
>
> I'm trying to delete this pass and don't want to add more stuff to it. If it's just for kernels can't you check for AGPR physreg uses later?

There two ways of getting AGPRs: use an MFMA and inline asm. For MFMA if we fit into register budget of 256 registers we can select _vgprcd versions and have no AGPRs, but that is not possible to do if there will be other AGPR uses.
This is too late to check for AGPR uses after selection, because it is needed for the selection.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117057/new/

https://reviews.llvm.org/D117057



More information about the llvm-commits mailing list