[PATCH] D104331: [AMDGPU] Use performOptimizedStructLayout for LDS sort

[Stanislav Mekhanoshin via Phabricator via llvm-commits]

rampitec added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPULowerModuleLDSPass.cpp:216
+    for (GlobalVariable *GV : FoundLocalVars) {
+      OptimizedStructLayoutField F(GV, DL.getTypeAllocSize(GV->getValueType()),
+                                   AMDGPU::getAlign(DL, GV));
----------------
JonChesterfield wrote:
> This asserts if the type has zero size. There's a repro that hits that internally at 317624. I'm not yet sure what to do with zero size fields.
I think we generally do not support opaque types. Anyhow there is no reasonable way to layout this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104331/new/

https://reviews.llvm.org/D104331