[PATCH] D116977: [llvm-ar] Enforce one-dash form for long options

Thu Jan 13 09:15:41 PST 2022

MaskRay added a comment.

In D116977#3240912 <https://reviews.llvm.org/D116977#3240912>, @sbc100 wrote:

> In D116977#3240895 <https://reviews.llvm.org/D116977#3240895>, @sbc100 wrote:
>
>> This change broke an emscripten test:
>>
>> https://ci.chromium.org/ui/p/emscripten-releases/builders/try/linux/b8825145660107382369/overview
>> https://logs.chromium.org/logs/emscripten-releases/buildbucket/cr-buildbucket/8825145660107382369/+/u/Emscripten_testsuite__upstream__other_/stdout
>>
>> The test in question was using `-version` with a single dash:
>>
>> https://github.com/emscripten-core/emscripten/blob/a246105a147e4a08981c4bdbe4e10f4103410604/tests/test_other.py#L570-L576
>
> Converted test so use the double-dash form, but I guess there could be other folks out there who get broken too?:
>
> https://github.com/emscripten-core/emscripten/pull/16007

If there is a justifiable issue, we can temporarily add `-version`, otherwise we don't need to take more defensive stance.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116977/new/

https://reviews.llvm.org/D116977