[PATCH] D116886: [M68k] Instruction selection to choose neg x when mul x -1 (Fix issue 48588)

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jan 13 05:55:33 PST 2022


myhsu accepted this revision.
myhsu added a comment.
This revision is now accepted and ready to land.

LGTM
Thank you!



================
Comment at: llvm/lib/Target/M68k/M68kISelDAGToDAG.cpp:326
+    case ISD::SUB:
+      if (llvm::isNullConstant(U->getOperand(0)))
+        return false;
----------------
it will be great to add a short description here to explain why you do this.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116886/new/

https://reviews.llvm.org/D116886



More information about the llvm-commits mailing list