[PATCH] D116993: [M68k] Add MC support for bchg, bclr and bset instruction
Min-Yih Hsu via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 13 05:52:27 PST 2022
myhsu added a comment.
Thanks for the patch.
Have you confirmed that codegen tests are not affected? You used the same isel patterns for all of the bit instructions (btst/bset/bclr etc.) which I don't think that's correct.
It's okay to add only the MC support for certain instructions but please leave the isel pattern empty.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116993/new/
https://reviews.llvm.org/D116993
More information about the llvm-commits
mailing list