[PATCH] D116928: [LoopVectorize] Support epilogue vectorisation of loops with reductions

[David Sherwood via Phabricator via llvm-commits]

david-arm added a comment.

This looks like a really nice change, thanks @kmclaughlin!



================
Comment at: llvm/lib/Transforms/Vectorize/LoopVectorize.cpp:8273
+
+  for (PHINode *Phi : PhisInBlock) {
+    Phi->replaceIncomingBlockWith(
----------------
nit: Is it possible to merge these two for loops together into one, i.e.

  for (PHINode &Phi : VecEpilogueIterationCountCheck->phis()) {


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116928/new/

https://reviews.llvm.org/D116928