[PATCH] D116730: [AArch64][SVE] Remove Redundant aarch64.sve.convert.to.svbool

[Peter Waller via Phabricator via llvm-commits]

peterwaller-arm accepted this revision.
peterwaller-arm added a comment.
This revision is now accepted and ready to land.

LGTM with some editorial suggestions.



================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:380-395
+/* (from_svbool (binop (to_svbool pred) (_) (_)))) =>
+   (binop (pred) (from_svbool _) (from_svbool _))
+
+   Functions which call a predicated binary operation where the type width for
+   the predicate is narrower than the two operands type widths and then returns
+   the result with the predicate width results in redundant operations being
+   generated. When widening the predicate type to the operand types with
----------------
Heads up, LLVM doesn't use c-style `/* */` comments. https://llvm.org/docs/CodingStandards.html#comment-formatting

I've had a go at editing the text here with the goal of simplifying it.


================
Comment at: llvm/lib/Target/AArch64/AArch64TargetTransformInfo.cpp:415
+  case Intrinsic::aarch64_sve_orn_z:
+    break;
+  case Intrinsic::aarch64_sve_orr_z:
----------------
You can elide all the `break;` here aside from the last one to shorten this switch a little.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116730/new/

https://reviews.llvm.org/D116730