[PATCH] D116668: libclc: Add clspv64 target
Kévin Petit via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jan 13 01:31:34 PST 2022
kpet closed this revision.
kpet marked an inline comment as done.
kpet added a comment.
Thanks! Now committed.
================
Comment at: libclc/CMakeLists.txt:308
+ set( t "spir64--" )
+ endif()
set( build_flags )
----------------
jvesely wrote:
> just add another `elseif` branch for better readability. Nested if is not saving much
I did it with nesting to mirror what was done for `spirv` and `spirv64` and de-duplicate flag setting. There are fewer flags with clspv* targets though. I've removed nesting and agree it's more readable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116668/new/
https://reviews.llvm.org/D116668
More information about the llvm-commits
mailing list