[PATCH] D117176: [bazel] Separate capi_deps from deps in mlir_c_api_cc_library.
Stella Laurenzo via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 12 17:51:27 PST 2022
stellaraccident marked an inline comment as done.
stellaraccident added inline comments.
================
Comment at: utils/bazel/llvm-project-overlay/mlir/build_defs.bzl:34
header_deps = [],
+ capi_deps = [],
**kwargs):
----------------
GMNGeoffrey wrote:
> Can you document this argument? I think we're getting in to the territory of non-obvious on this one. I would probably just bite the bullet and do the standard "Args:" block, but mostly because I'm used to linters complaining if I don't do exactly that. I would say that header_deps and capi_deps are worth documenting here, at least.
How's that?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117176/new/
https://reviews.llvm.org/D117176
More information about the llvm-commits
mailing list