[llvm] 71af806 - [JITLink] Fix assert condition broken in 118e953b18ff0.

Lang Hames via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 12 17:06:31 PST 2022


Author: Lang Hames
Date: 2022-01-13T12:06:25+11:00
New Revision: 71af8068ac1283eb7ede70cc841af95acb11bdeb

URL: https://github.com/llvm/llvm-project/commit/71af8068ac1283eb7ede70cc841af95acb11bdeb
DIFF: https://github.com/llvm/llvm-project/commit/71af8068ac1283eb7ede70cc841af95acb11bdeb.diff

LOG: [JITLink] Fix assert condition broken in 118e953b18ff0.

The condition was accidentally changed from A != InvalidAddr to A != 0, this
commit changes it back.

Added: 
    

Modified: 
    llvm/include/llvm/ExecutionEngine/JITLink/JITLinkMemoryManager.h

Removed: 
    


################################################################################
diff  --git a/llvm/include/llvm/ExecutionEngine/JITLink/JITLinkMemoryManager.h b/llvm/include/llvm/ExecutionEngine/JITLink/JITLinkMemoryManager.h
index d094704cc5890..abfeafe798e79 100644
--- a/llvm/include/llvm/ExecutionEngine/JITLink/JITLinkMemoryManager.h
+++ b/llvm/include/llvm/ExecutionEngine/JITLink/JITLinkMemoryManager.h
@@ -60,7 +60,8 @@ class JITLinkMemoryManager {
   public:
     FinalizedAlloc() = default;
     explicit FinalizedAlloc(orc::ExecutorAddr A) : A(A) {
-      assert(A && "Explicitly creating an invalid allocation?");
+      assert(A.getValue() != InvalidAddr &&
+             "Explicitly creating an invalid allocation?");
     }
     FinalizedAlloc(const FinalizedAlloc &) = delete;
     FinalizedAlloc(FinalizedAlloc &&Other) : A(Other.A) {


        


More information about the llvm-commits mailing list