[PATCH] D117173: [ORC-RT] Hook objc's class_getImageName for JITDylibs

[Ben Langmuir via Phabricator via llvm-commits]

benlangmuir added inline comments.


================
Comment at: compiler-rt/lib/orc/macho_platform.cpp:372
+    };
+    ORC_RT_DEBUG(printdbg("objc_setHook_getImageName not available; "
+                          "class_getImageName will not work for JITDylibs"));
----------------
I wasn't 100% sure whether this should be a log message or an error.  The other objc functionality uses errors, but in those cases the objc code will fail completely if you're missing the runtime functions. In this case, `class_getImageName` returning nullptr doesn't seem bad enough to make it a hard error to me -- you might not be using that at all.  It's too bad there's no such thing as a runtime warning.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117173/new/

https://reviews.llvm.org/D117173