[PATCH] D117168: [SROA] Bail out on PHIs in catchswitch BBs

[Heejin Ahn via Phabricator via llvm-commits]

aheejin created this revision.
aheejin added a reviewer: majnemer.
Herald added subscribers: wingo, hiraditya.
aheejin requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

In the process of rewriting `alloca`s and `phi`s that use them, the SROA
pass can try to insert a non-PHI instruction by calling
getFirstInsertionPt(), which is not possible in a catchswitch BB. This
CL makes we bail out on these cases.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117168

Files:
  llvm/lib/Transforms/Scalar/SROA.cpp
  llvm/test/Transforms/SROA/phi-catchswitch.ll


Index: llvm/test/Transforms/SROA/phi-catchswitch.ll
===================================================================
--- /dev/null
+++ llvm/test/Transforms/SROA/phi-catchswitch.ll
@@ -0,0 +1,40 @@
+target datalayout = "e-m:e-p:32:32-p10:8:8-p20:8:8-i64:64-f128:64-n32:64-S128-ni:1:10:20"
+target triple = "wasm32-unknown-emscripten"
+
+%struct.foo = type { i32 }
+declare i32 @__gxx_wasm_personality_v0(...)
+declare void @foo()
+
+; Tests if the SROA pass correctly bails out on rewriting PHIs in a catchswitch
+; BB.
+define void @test_phi_catchswitch() personality i8* bitcast (i32 (...)* @__gxx_wasm_personality_v0 to i8*) {
+entry:
+  %tmp = alloca %struct.foo, align 4
+  %tmp2 = getelementptr inbounds %struct.foo, %struct.foo* %tmp, i32 0, i32 0
+  invoke void @foo()
+          to label %bb3 unwind label %bb10
+
+bb3:
+  invoke void @foo()
+          to label %bb9 unwind label %catch.dispatch
+
+catch.dispatch:
+  ; While rewriting the alloca in the entry BB, the SROA pass tries to insert a
+  ; non-PHI instruction in this BB by calling getFirstInsertionPt(), which is
+  ; not possible in a catchswitch BB. This test checks if we correctly bail out
+  ; on these cases.
+  %tmp6 = catchswitch within none [label %catch.start] unwind label %bb10
+
+catch.start:
+  %tmp8 = catchpad within %tmp6 [i8* null]
+  unreachable
+
+bb9:
+  unreachable
+
+bb10:
+  %tmp11 = phi i32* [ %tmp2, %entry ], [ %tmp5, %catch.dispatch ]
+  %tmp12 = cleanuppad within none []
+  store i32 0, i32* %tmp11, align 4
+  unreachable
+}
Index: llvm/lib/Transforms/Scalar/SROA.cpp
===================================================================
--- llvm/lib/Transforms/Scalar/SROA.cpp
+++ llvm/lib/Transforms/Scalar/SROA.cpp
@@ -1008,6 +1008,13 @@
     if (I.use_empty())
       return markAsDead(I);
 
+    // If this is a PHI node before a catchswitch, we cannot insert any non-PHI
+    // instructions in this BB, which may be required during rewriting. Bail out
+    // on these cases.
+    if (isa<PHINode>(I) &&
+        I.getParent()->getFirstInsertionPt() == I.getParent()->end())
+      return PI.setAborted(&I);
+
     // TODO: We could use SimplifyInstruction here to fold PHINodes and
     // SelectInsts. However, doing so requires to change the current
     // dead-operand-tracking mechanism. For instance, suppose neither loading


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117168.399496.patch
Type: text/x-patch
Size: 2342 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220112/47193d44/attachment.bin>