[PATCH] D116832: [UpdateLLCTestChecks] Allow replacing register names with variables

[David Greene via Phabricator via llvm-commits]

greened added a comment.

> All of the examples you have provided show non-register-changes in the same tests, so the tests would still need re-generating. After re-generating, would all the register name updates still not be part of the diff on exactly the same lines?

You're right, they would and I should fix that.  Thanks for the feedback!

>> I have had discussions with the people that originally created the `update_*` scripts and they were clear the intent was *not* to just blindly run it and submit the result without careful hand-editing.
>
> The tests get a header that specifically tells you exactly which script to run with which options to fully automatically update them; regardless of original intent, that is how these `update_*` scripts are used now, for better or worse.

That sidesteps the issue, which is that we have tests with no documentation of what they're testing.  The fact that `update_*` scripts check *all* of the output exacerbates that.  Sure, for better or worse but I'd like to make it better.  :)

>> I could certainly alter this to uniquify names if it would help.
>
> If you can find a good way to do that, so that register name updates do actually get kept out of diffs, then yes I can see how this may help.

Ok, I'll see what I can do!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116832/new/

https://reviews.llvm.org/D116832