[PATCH] D115327: [WebAssembly] Fix reftype load/store match with idx from call

Thomas Lively via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 12 14:02:06 PST 2022


tlively added inline comments.


================
Comment at: llvm/lib/Target/WebAssembly/WebAssemblyISelLowering.cpp:1494
       Idx = Base->getOperand(1);
-      if (!Idx || GA->getNumValues() != 1 || Idx->getNumValues() != 1)
+      if (GA->getNumValues() != 1)
         return false;
----------------
Should this just be an assertion? I would be surprised if a `GlobalAddressSDNode` could ever have more than one value.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115327/new/

https://reviews.llvm.org/D115327



More information about the llvm-commits mailing list