[PATCH] D117066: RuntimeDyldELF: Don't abort on R_AARCH64_NONE relocation

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/ExecutionEngine/RuntimeDyld/AArch64/ELF_ARM64_none.yaml:4
+
+# Verify rtdyld doesn't abort in presence of R_AARCH64_NONE
+
----------------
`.` after a complete sentence.

In other ELF components we prefer `## ` for non-RUN non-CHECK comments. I haven't checked whether test/ExecutionEngine wants to follow this convention.


================
Comment at: llvm/test/ExecutionEngine/RuntimeDyld/AArch64/ELF_ARM64_none.yaml:24
+        Type:            R_AARCH64_NONE
+Symbols:
+  - Name: _main
----------------
remove

R_AARCH64_NONE doesn't need a symbol


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117066/new/

https://reviews.llvm.org/D117066