[PATCH] D116977: [llvm-ar] Enforce one-dash form for long options

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/plugin.test:1
+## Test that --plugin is ignored.
+
----------------
MaskRay wrote:
> jhenderson wrote:
> > Seems tangential to this patch? Test is fine, but probably should be committed separately.
> > 
> > Any particular reason you don't test the single-dash version here, but you do in the --format and --version options?
> Yes, I plan to commit this separately.
> 
> > Any particular reason you don't test the single-dash version here, but you do in the --format and --version options?
> 
> Just thought it seems excessive to test every long option. --format and --version have good coverage.
Pushed separately in f8476fd47b539a14d6a8994e7a5e6401f9ed2a98


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116977/new/

https://reviews.llvm.org/D116977