[PATCH] D114916: [LoopInterchange] Enable loop interchange with multiple outer loop indvars

[Bardia Mahjour via Phabricator via llvm-commits]

bmahjour added a comment.

Looks good....I just added a couple more comments in the tests. Once they are addressed, I'll accept this revision.



================
Comment at: llvm/test/Transforms/LoopInterchange/interchangeable-outerloop-multiple-indvars.ll:19
+; CHECK-LABEL: @test1(
+; CHECK:  for.cond2.preheader:
+; CHECK:    [[INDVAR0:%.*]] = phi i64 [ [[INDVAR0_NEXT:%.*]], [[FOR_INC7:%.*]] ], [ 0, [[FOR_COND2_PREHEADER_PREHEADER:%.*]] ]
----------------
Please use CHECK-NEXT and show full context


================
Comment at: llvm/test/Transforms/LoopInterchange/interchangeable-outerloop-multiple-indvars.ll:101
+; CHECK-LABEL: @test2(
+; CHECK:  for.cond2.preheader:
+; CHECK:    [[INDVAR0:%.*]] = phi i64 [ [[INDVAR0_NEXT:%.*]], [[FOR_INC7:%.*]] ], [ 0, [[FOR_COND2_PREHEADER_PREHEADER:%.*]] ]
----------------
Same comment as above.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D114916/new/

https://reviews.llvm.org/D114916