[PATCH] D117117: [FileCheck] Allow literal '['s before "[[var...]]"

Thomas Preud'homme via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 12 07:50:13 PST 2022


thopre added a comment.

Could you add a new testcase somewhere in `llvm/test/FileCheck`? Thanks!



================
Comment at: llvm/lib/FileCheck/FileCheck.cpp:1194
+    size_t FixedMatchEnd =
+        std::min(PatternStr.find("{{", 1), PatternStr.find("[[", 1));
     RegExStr += Regex::escape(PatternStr.substr(0, FixedMatchEnd));
----------------
Why the special treatment for `{{` here since only the `[[[` case is handled above?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117117/new/

https://reviews.llvm.org/D117117



More information about the llvm-commits mailing list