[PATCH] D113825: [llvm-readobj][XCOFF] dump auxiliary symbols.

[Nico Weber via Phabricator via llvm-commits]

thakis added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/XCOFF/symbols-invalid.test:6
+
+# CASE1: llvm-readobj: warning: '[[FILE]]': the non-function C_EXT symbol at index 1 should have only 1 auxiliary entry, i.e. the CSECT auxiliary entry
+
----------------
thakis wrote:
> jhenderson wrote:
> > The problem is a missing `{{(.exe)?}}` after the tool name. Usually, we don't include tool names in the check, and just check from "warning:" onwards.
> > 
> > Applies throughout this test.
> Hm, normally we don't print "toolname.exe: " in diags on Windows, but just "toolname: ". We usually also don't print the full path to the tool but just the basename.
> 
> Maybe the Right Fix is to fix the diag output in llvm-readobj instead?
(…but that seems admittedly mostly independent of this patch here. So for relanding, just fixing the test expectations is fine too.)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D113825/new/

https://reviews.llvm.org/D113825