[PATCH] D117100: [flang][nfc] Update README.md

Andrzej Warzynski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 12 02:48:13 PST 2022


awarzynski created this revision.
awarzynski added reviewers: rovka, PeteSteinfeld.
Herald added subscribers: Chia-hungDuan, rriddle.
Herald added a project: Flang.
awarzynski requested review of this revision.
Herald added subscribers: llvm-commits, stephenneuendorffer, jdoerfert.
Herald added a project: LLVM.

With https://reviews.llvm.org/D116731 merged, installing Clang, MLIR or
LLVM is no longer required for standalone builds. For consistency sake,
remove "installation" from the build instrucitons.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117100

Files:
  flang/README.md


Index: flang/README.md
===================================================================
--- flang/README.md
+++ flang/README.md
@@ -65,10 +65,8 @@
 Once the clone is complete, execute the following commands:
 ```bash
 cd my-project
-INSTALLDIR=`pwd`/install
 
 rm -rf build
-rm -rf install
 mkdir -p build
 
 cd build
@@ -93,12 +91,6 @@
 ninja check-flang
 ```
 
-If you're happy with the results, the next step is to create the install area.
-While in the `build` directory, run the command:
-```bash
-ninja install
-```
-
 Note that these instructions specify flang as one of the projects to build in
 the in tree build.  This is not strictly necessary for subsequent standalone
 builds, but doing so lets you run the flang tests to verify that the source
@@ -129,18 +121,12 @@
   -DLLVM_BUILD_MAIN_SRC_DIR=$base/build/lib/cmake/llvm \
   -DLLVM_LIT_ARGS=-v \
   -DLLVM_DIR=$base/build/lib/cmake/llvm \
-  -DCLANG_DIR=$base/install/lib/cmake/clang \
-  -DMLIR_DIR=$base/install/lib/cmake/mlir \
+  -DCLANG_DIR=$base/build/lib/cmake/clang \
+  -DMLIR_DIR=$base/build/lib/cmake/mlir \
   ..
 
 ninja
 ```
-Note that for Clang and MLIR you use the installation directory ($base/install)
-and for LLVM you use the build directory (`$base/build`).   This is not a typo
-in the script.  Rather, it is because running the tests requires the GTest
-infrastructure which is only available in the LLVM build area.  The build also
-requires the `AddClang.cmake` script from Clang, which is only available in the
-install area.
 
 To run the flang tests on this build, execute the command in the "flang/build"
 directory:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117100.399277.patch
Type: text/x-patch
Size: 1615 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220112/b44e8eeb/attachment.bin>


More information about the llvm-commits mailing list