[PATCH] D116832: [UpdateLLCTestChecks] Allow replacing register names with variables

Phoebe Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 21:20:39 PST 2022


pengfei added a comment.

> We have a huge issue with codegen churn causing pages of testcase changes in proposed merges and very little review is done on them.

Can you show an example?

> How so? I'm struggling to think of a time a regexp hid a real problem. Can you explain a bit more?

Here is one example: https://github.com/llvm/llvm-project/blob/main/llvm/test/CodeGen/X86/distancemap.mir#L66
The several `[[COPY6:%[0-9]+]]` are totally different things. I was fooled during the review. That's why I hate it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116832/new/

https://reviews.llvm.org/D116832



More information about the llvm-commits mailing list