[PATCH] D111417: [Demangle] Add support for D symbols back referencing

Luís Ferreira via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 19:24:43 PST 2022


ljmf00 added inline comments.


================
Comment at: llvm/lib/Demangle/DLangDemangle.cpp:80
+  ///
+  /// \note a result <= 0 is a failure.
+  ///
----------------
dblaikie wrote:
> Since the function already communicates failure via a null return - should this maybe be an invariant/assertion/postcondition ("Ret is always >=0 on success, and unspecified on failure" or something like that?)
Right. Changed the documentation as suggested.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D111417/new/

https://reviews.llvm.org/D111417



More information about the llvm-commits mailing list