[PATCH] D116971: [AttributorAttributes] Remove hardcoded parameters

Bryce Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 18:40:44 PST 2022


Bryce-MW added a comment.

I am unsure why tools/llvm-libtool-darwin/L-and-l.test failed on Windows. It didn't fail before and seems completely unrelated. I've done a rebase in case that helps.

I would prefer not to use getAllocSizeArgs inside of getSize over using getObjectSize but the former passes the tests and the latter doesn't. Perhaps it is a bug in getObjectSize but I don't understand that function well enough.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116971/new/

https://reviews.llvm.org/D116971



More information about the llvm-commits mailing list