[PATCH] D110579: [AMDGPU] Add two new intrinsics to control fp_trunc rounding mode

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:6337
+    const Function *F = I.getCalledFunction();
+    bool HasChain = !F->doesNotAccessMemory();
+    bool OnlyLoad = HasChain && F->onlyReadsMemory();
----------------
craig.topper wrote:
> Why would this intrinsic ever have a chain?
Err. I guess the intrinsic attributes are defined to always have a Chain. Should it be IntrNoMem instead?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D110579/new/

https://reviews.llvm.org/D110579