[PATCH] D116985: [MLGO] Add support for multiple training traces per module

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin marked an inline comment as done.
mtrofin added inline comments.


================
Comment at: llvm/unittests/Analysis/TFUtilsTest.cpp:311
+  google::protobuf::Struct Expected;
+  EXPECT_TRUE(Expected.ParseFromString(Result));
+  EXPECT_EQ(Expected.fields_size(), 2);
----------------
snehasish wrote:
> This should be ASSERT_TRUE since if parsing from Result fails the following EXPECT checks should not be executed.
> 
> https://testing.googleblog.com/2008/07/tott-expect-vs-assert.html
Good catch, thanks - that goes for the other tests too, I'll fix separately first.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116985/new/

https://reviews.llvm.org/D116985