[compiler-rt] ff11cd9 - [TSan][Darwin] Enable Trace/TraceAlloc unit tests

Julian Lettner via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 15:33:34 PST 2022


Author: Julian Lettner
Date: 2022-01-11T15:33:29-08:00
New Revision: ff11cd95501931e499a1ead748e8857f40ba5a4d

URL: https://github.com/llvm/llvm-project/commit/ff11cd95501931e499a1ead748e8857f40ba5a4d
DIFF: https://github.com/llvm/llvm-project/commit/ff11cd95501931e499a1ead748e8857f40ba5a4d.diff

LOG: [TSan][Darwin] Enable Trace/TraceAlloc unit tests

These tests are now green:
```
  Trace.MultiPart
  Trace.RestoreAccess
  Trace.RestoreMutexLock
  TraceAlloc.FinishedThreadReuse
  TraceAlloc.FinishedThreadReuse2
  TraceAlloc.SingleThread
```

rdar://82107856

Added: 
    

Modified: 
    compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp b/compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp
index a9f552c8ba9b1..d133dcb1a4ebf 100644
--- a/compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp
+++ b/compiler-rt/lib/tsan/tests/unit/tsan_trace_test.cpp
@@ -16,10 +16,9 @@
 #include "gtest/gtest.h"
 #include "tsan_rtl.h"
 
-#if SANITIZER_MAC || !defined(__x86_64__)
-// These tests are currently crashing on Mac:
-// https://reviews.llvm.org/D107911
-// and on ppc64: https://reviews.llvm.org/D110546#3025422
+#if !defined(__x86_64__)
+// These tests are currently crashing on ppc64:
+// https://reviews.llvm.org/D110546#3025422
 // due to the way we create thread contexts
 // (but they crashed on Mac with normal pthread_create as well).
 // There must be some 
diff erence in thread initialization


        


More information about the llvm-commits mailing list