[PATCH] D112164: [lld-macho] Port CallGraphSort from COFF/ELF

[Leonard Grey via Phabricator via llvm-commits]

lgrey added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1401
       parseOrderFile(orderFile);
+      config->callGraphProfileSort = false;
+    }
----------------
thakis wrote:
> should we warn if there's both an explicit `--call-graph-profile-sort` flag and an `-order_file` flag? Or maybe later when we know that there's call graph info in the .o file but also an order file?
> 
> (…or are you planning on adding support for both flags at the same time in a follow-up?)
Yes, planning to add support to both as a follow-up


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D112164/new/

https://reviews.llvm.org/D112164