[PATCH] D116997: [CodeGen][Debuginfo][NFC] Refactor DIE values SizeOf method to not depend on AsmPrinter.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 14:15:47 PST 2022


MaskRay accepted this revision.
MaskRay added a comment.

One nit



================
Comment at: llvm/include/llvm/BinaryFormat/Dwarf.h:654
+  /// .debug_* sections.
+  bool DwarfUsesRelocationsAcrossSections = false;
 
----------------
I didn't check what this is. For newer code, `DWARF vN` is preferred over `DwarfN`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116997/new/

https://reviews.llvm.org/D116997



More information about the llvm-commits mailing list