[PATCH] D116855: Add 'eager-checks' as a module parameter to MSAN.

[Kevin Athey via Phabricator via llvm-commits]

kda added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/MemorySanitizer.cpp:701-703
+  OS << "track-origins=" << Options.TrackOrigins << ";";
+  if (Options.EagerChecks)
+    OS << "eager-checks;";
----------------
vitalybuka wrote:
> This breaks existing new-pm-print-pipeline.ll test for me (check-llvm)
> Maybe flip like this to avoid ; before >
> 
> Please add something for EagerChecks into new-pm-print-pipeline.ll as well
for the record: the only reason the trailing ';' is never against the '>', is because 'track-origins' is always included.  There would need to be more logic to correctly avoid the sequence ';>'.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116855/new/

https://reviews.llvm.org/D116855