[PATCH] D116964: [NFC][MLGO] Use LazyCallGraph::Node to track functions.

Mircea Trofin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 12:51:16 PST 2022


mtrofin marked 3 inline comments as done.
mtrofin added inline comments.


================
Comment at: llvm/include/llvm/Analysis/MLInlineAdvisor.h:12
 
 #include "llvm/Analysis/CallGraph.h"
 #include "llvm/Analysis/InlineAdvisor.h"
----------------
aeubanks wrote:
> shouldn't need this anymore
Right. I'll move it to the .cpp because i'm still using it just to populate some initial state (I want to yank it though if I figure out how)


================
Comment at: llvm/include/llvm/Analysis/MLInlineAdvisor.h:76
+  // infrequently.
+  DenseSet<const LazyCallGraph::Node *> DeletedFunctions;
 };
----------------
nikic wrote:
> Where is DeletedFunctions used now?
Nowhere  - thanks for the catch!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116964/new/

https://reviews.llvm.org/D116964



More information about the llvm-commits mailing list