[PATCH] D116964: [NFC][MLGO] Use LazyCallGraph::Node to track functions.
Mircea Trofin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 11 12:33:08 PST 2022
mtrofin marked an inline comment as done.
mtrofin added inline comments.
================
Comment at: llvm/lib/Analysis/DevelopmentModeInlineAdvisor.cpp:408
size_t DevelopmentModeMLInlineAdvisor::getTotalSizeEstimate() {
if (!InlineSizeEstimatorAnalysis::isEvaluatorRequested())
----------------
aeubanks wrote:
> AFAICT, this is only called in the constructor of `DevelopmentModeMLInlineAdvisor` where we shouldn't have any deleted functions. and `isFunctionDeleted()` is only referenced here. is `isFunctionDeleted()` still necessary?
yup - thanks! removed it.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116964/new/
https://reviews.llvm.org/D116964
More information about the llvm-commits
mailing list