[PATCH] D116997: [CodeGen][Debuginfo][NFC] Refactor DIE values SizeOf method to not depend on AsmPrinter.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/DIE.h:936
 
   /// ComputeSize - Calculate the size of the location expression.
   ///
----------------
As you switch the case, make a minor change per
https://llvm.org/docs/CodingStandards.html#doxygen-use-in-documentation-comments
"Don’t duplicate the documentation comment in the header file and in the implementation file."

And remove the otherwise empty `///`


================
Comment at: llvm/include/llvm/CodeGen/DIE.h:938
   ///
-  unsigned ComputeSize(const AsmPrinter *AP) const;
+  unsigned ComputeSize(const dwarf::FormParams &FormParams) const;
 
----------------



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116997/new/

https://reviews.llvm.org/D116997