[PATCH] D116821: [DebugInfo][InstrRef] Move instr-ref controlling flag out of TargetOptions

Jeremy Morse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 10:01:39 PST 2022


jmorse added a comment.

Cheers Stephen; I'm leaning towards not adding or altering tests here -- there's already a test for this option, and that LLVM does the right thing in LLC. What changes is a matter of storage: instead of the flag being stored in TargetOptions, which every frontend initializes itself it seems, it's now a (global) flag to LLVM. I'd prefer to stay away from parsing MIR in clang tests!.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116821/new/

https://reviews.llvm.org/D116821



More information about the llvm-commits mailing list