[PATCH] D116838: [ELF] -Map --why-extract=: print despite errors

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 09:04:09 PST 2022


peter.smith accepted this revision.
peter.smith added a comment.
This revision is now accepted and ready to land.

Thanks for the update LGTM on my side. It could be worth adding a comment after finalizeAddressDependentContent() just before the error check, to say something like `All information needed for OutputSection part of Map file available.` That might help someone that adds an extra error check and sees a test fail.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116838/new/

https://reviews.llvm.org/D116838



More information about the llvm-commits mailing list