[PATCH] D117005: [DSE] Remove alloc function check in canSkipDef()

Philip Reames via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 08:36:34 PST 2022


reames added a comment.

FWIW, I'm also quite confused by this code.  My best guess was that maybe this was handling the case where we introduced a new memory region (e.g. the return noalias) as opposed to merely writing to an existing region, but that's somewhat a guess.  I don't see that distinction made in the DSE code, and I'm not sure how memory-ssa models that.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117005/new/

https://reviews.llvm.org/D117005



More information about the llvm-commits mailing list