[PATCH] D116977: [llvm-ar] Enforce one-dash form for long options

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 08:34:22 PST 2022


MaskRay added inline comments.


================
Comment at: llvm/test/tools/llvm-ar/plugin.test:1
+## Test that --plugin is ignored.
+
----------------
jhenderson wrote:
> Seems tangential to this patch? Test is fine, but probably should be committed separately.
> 
> Any particular reason you don't test the single-dash version here, but you do in the --format and --version options?
Yes, I plan to commit this separately.

> Any particular reason you don't test the single-dash version here, but you do in the --format and --version options?

Just thought it seems excessive to test every long option. --format and --version have good coverage.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116977/new/

https://reviews.llvm.org/D116977



More information about the llvm-commits mailing list