[PATCH] D109584: Implementing expansion pass for VP load and store.

Simon Moll via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 11 02:15:44 PST 2022


simoll added inline comments.


================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:785
+  case Intrinsic::vp_store:
+    if (isEVLOnlyMemoryIntrinsic(VPI)) {
+      return expandPredicationInUnfoldedLoadStore(Builder, VPI);
----------------
simoll wrote:
> We should pick the expansion strategy based on the target's preferences. Either extend `VPLegalizationStrategy` to allow for strategy selection or add a new function to TTI that returns the expansion method (enum).
load/store unfolding does not work for scalable vectors this way. We should default to the memory intrinsic path for scalable types.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109584/new/

https://reviews.llvm.org/D109584



More information about the llvm-commits mailing list