[PATCH] D109584: Implementing expansion pass for VP load and store.

[Simon Moll via Phabricator via llvm-commits]

simoll added a comment.

I'm still in favor of splitting up the patch into the default expansion (which can be the cascading loads) and a second one for masked.load expansion.



================
Comment at: llvm/lib/CodeGen/ExpandVectorPredication.cpp:713
+    if ((isAllTrueMask(Mask) || isa<UndefValue>(Mask)) &&
+        !TTI.isLegalMaskedLoad(VPI.getType(),
+                               VPI.getPointerAlignment().valueOrOne()))
----------------
I had overlooked this before. You are checking whether `masked.load` is supported, so my argument for selecting the expansion scheme with TTI is moot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109584/new/

https://reviews.llvm.org/D109584