[PATCH] D116886: [M68k] Instruction selection to choose neg x when mul x -1 (Fix issue 48588)

[Douglas Chen via Phabricator via llvm-commits]

dougpuob marked an inline comment as done.
dougpuob added inline comments.


================
Comment at: llvm/lib/Target/M68k/M68kISelDAGToDAG.cpp:327
+      if (llvm::isNullConstant(U->getOperand(0)))
+        return false;
+    }
----------------
RKSimon wrote:
> (style) Add a break - even though its the last case in the switch() its good practice to use them.
Agree with you. Thank you for your careful found.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116886/new/

https://reviews.llvm.org/D116886