[PATCH] D116327: [Coroutines] Enhance symmetric transfer for constant CmpInst

JunMa via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 10 19:59:46 PST 2022


junparser added a comment.

This is general LGTM with some comments



================
Comment at: llvm/lib/Transforms/Coroutines/CoroSplit.cpp:1227
+
+      BasicBlock *BB = BR->getParent();
+      // Handle the case the condition of the conditional branch is constant.
----------------
Instead simplify each instructions at pieces,would you use SimplifyInstructionsInBlock to handle each basic block at once?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116327/new/

https://reviews.llvm.org/D116327



More information about the llvm-commits mailing list