[PATCH] D116890: [RISCV] Add initial support for getRegUsageForType and getNumberOfRegisters

Kito Cheng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 10 19:43:13 PST 2022


kito-cheng added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVTargetTransformInfo.cpp:292
+
+  unsigned FLen = ST->getFLen();
+  if (FLen && Ty->isFloatingPointTy())
----------------
craig.topper wrote:
> Can we fall back to the default implementation for non-vector?
Although I think the default one is not good, but we didn't find good way to testing those part yet, so OK to me.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116890/new/

https://reviews.llvm.org/D116890



More information about the llvm-commits mailing list